Expose LocalAccessor as kernel argument type by oleksandr-pavlyk · Pull Request #1991 · IntelPython/dpctl

oleksandr-pavlyk · 2025-02-10T23:16:51Z

This PR adds _md_local_accessor Cython struct in _backend.pxd that ties to MDLocalAccessor struct defined in libsyclinterface, and which is to be used to indicate local_accessor kernel argument type (see test file in syclinterface library).

_sycl_queue.pyx then defines LocalAccessor type, constructible using LocalAccessor(ndim, typestr, dim0, dim1, dim2) constuctor. The ndim argument represents accessor dimensionality (only values 1, 2, or 3 are supported). The typestr can be "i1", "u1", "i2", "u2", "i4", "u4", "i8", "u8", "f4", or "f8".

Have you provided a meaningful PR description?
Have you added a test, reproducer or referred to an issue with a reproducer?
Have you tested your changes locally for CPU and GPU devices?
Have you made sure that new changes do not introduce compiler warnings?
Have you checked performance impact of proposed changes?
Have you added documentation for your changes, if necessary?
Have you added your changes to the changelog?
If this PR is a work in progress, are you opening the PR as a draft?

github-actions · 2025-02-10T23:53:01Z

Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞

github-actions · 2025-02-11T00:00:35Z

Array API standard conformance tests for dpctl=0.19.0dev0=py310h93fe807_518 ran successfully.
Passed: 894
Failed: 2
Skipped: 118

dpctl/_sycl_queue.pyx

github-actions · 2025-02-17T02:46:55Z

Array API standard conformance tests for dpctl= ran successfully.
Passed: 894
Failed: 2
Skipped: 118

coveralls · 2025-02-17T02:49:05Z

coverage: 87.652% (-0.2%) from 87.855%
when pulling 1d3453e on add-md-local-accessor
into 96da90b on master.

github-actions · 2025-02-21T21:44:06Z

Array API standard conformance tests for dpctl=0.19.0dev0=py310h93fe807_540 ran successfully.
Passed: 894
Failed: 2
Skipped: 118

dpctl/_sycl_queue.pyx

dpctl/tests/test_sycl_kernel_submit.py

github-actions · 2025-02-27T09:20:35Z

Array API standard conformance tests for dpctl=0.20.0dev0=py310h93fe807_11 ran successfully.
Passed: 894
Failed: 2
Skipped: 118

github-actions · 2025-02-27T19:57:15Z

Array API standard conformance tests for dpctl=0.20.0dev0=py310h93fe807_11 ran successfully.
Passed: 893
Failed: 3
Skipped: 118

github-actions · 2025-02-27T23:04:55Z

Array API standard conformance tests for dpctl=0.20.0dev0=py310h93fe807_11 ran successfully.
Passed: 896
Failed: 1
Skipped: 125

dpctl/_sycl_queue.pyx

…cessor

…uments LocalAccessor(ndim, elemental_type_str, dim0, dim1, dim2) The elemental type can be one of the following: "i1", "u1", "i2", "u2", "i4", "u4", "i8", "u8", "f4", "f8"

Fixes conflict with built-in `type`

Also improve messages in errors

…el_submit.py

github-actions · 2025-03-07T22:06:47Z

Array API standard conformance tests for dpctl=0.20.0dev0=py310h93fe807_41 ran successfully.
Passed: 895
Failed: 2
Skipped: 126

…parate integer arguments Update test for LocalAccessor kernel submission

github-actions · 2025-03-08T09:06:48Z

Array API standard conformance tests for dpctl=0.20.0dev0=py310h93fe807_42 ran successfully.
Passed: 894
Failed: 3
Skipped: 126

vtavana

Thank you, @ndgrigorian, for finalizing it!

dpctl/tests/test_sycl_kernel_submit.py

Also slips in a fix to the shape of the local_accessor

github-actions · 2025-03-11T01:14:40Z

Array API standard conformance tests for dpctl=0.20.0dev0=py310h93fe807_45 ran successfully.
Passed: 895
Failed: 2
Skipped: 126

oleksandr-pavlyk requested a review from ndgrigorian as a code owner February 10, 2025 23:16

sommerlukas mentioned this pull request Feb 12, 2025

Add support for work_group_memory extension #1984

Merged

7 tasks

ndgrigorian reviewed Feb 14, 2025

View reviewed changes

dpctl/_sycl_queue.pyx Outdated Show resolved Hide resolved

ndgrigorian requested review from antonwolfy, vlad-perevezentsev and vtavana as code owners February 21, 2025 21:02

sommerlukas reviewed Feb 24, 2025

View reviewed changes

dpctl/_sycl_queue.pyx Outdated Show resolved Hide resolved

dpctl/tests/test_sycl_kernel_submit.py Show resolved Hide resolved

ndgrigorian force-pushed the add-md-local-accessor branch from ff43ac7 to e1e4b00 Compare February 27, 2025 08:38

ndgrigorian force-pushed the add-md-local-accessor branch from e1e4b00 to 949571b Compare February 27, 2025 19:14

ndgrigorian force-pushed the add-md-local-accessor branch from 949571b to f35e483 Compare February 27, 2025 22:22

sommerlukas reviewed Feb 28, 2025

View reviewed changes

dpctl/_sycl_queue.pyx Outdated Show resolved Hide resolved

oleksandr-pavlyk and others added 9 commits March 7, 2025 13:18

Export _md_local_accessor Cython struct, mapped to C struct MDLocalAc…

b6d639a

…cessor

Define LocalAccessor type to use to specify local accessor kernel arg…

fd01ba5

…uments LocalAccessor(ndim, elemental_type_str, dim0, dim1, dim2) The elemental type can be one of the following: "i1", "u1", "i2", "u2", "i4", "u4", "i8", "u8", "f4", "f8"

Add Python tests for kernel submission with LocalAccessor

c0019d5

Fix typo in _md_local_accessor error message

c849993

type->dtype in LocalAccessor initialization

1f94e7f

Fixes conflict with built-in `type`

Add docstrings to LocalAccessor

76fdd08

Also improve messages in errors

Add a comment documenting the origin of spirv files in test_sycl_kern…

5c07e44

…el_submit.py

Add LocalAccessor to dpctl namespace

6cdb80c

Fix __repr__ in LocalAccessor

5fc86c6

ndgrigorian force-pushed the add-md-local-accessor branch from f35e483 to 5fc86c6 Compare March 7, 2025 21:22

LocalAccessor takes a sequence of non-negative integers instead of se…

b5887df

…parate integer arguments Update test for LocalAccessor kernel submission

ndgrigorian requested a review from sommerlukas March 8, 2025 08:24

sommerlukas approved these changes Mar 10, 2025

View reviewed changes

ndgrigorian previously approved these changes Mar 10, 2025

View reviewed changes

vtavana previously approved these changes Mar 11, 2025

View reviewed changes

dpctl/tests/test_sycl_kernel_submit.py Outdated Show resolved Hide resolved

Address review comments on test_submit_local_accessor_arg

1d3453e

Also slips in a fix to the shape of the local_accessor

ndgrigorian dismissed stale reviews from vtavana and themself via 1d3453e March 11, 2025 00:32

ndgrigorian requested a review from vtavana March 11, 2025 00:32

vtavana approved these changes Mar 11, 2025

View reviewed changes

ndgrigorian merged commit c3e6952 into master Mar 11, 2025
73 of 74 checks passed

ndgrigorian deleted the add-md-local-accessor branch March 11, 2025 05:40

Conversation

oleksandr-pavlyk commented Feb 10, 2025 • edited by vtavana Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Feb 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Feb 11, 2025

Uh oh!

Uh oh!

github-actions bot commented Feb 17, 2025

Uh oh!

coveralls commented Feb 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Feb 21, 2025

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Feb 27, 2025

Uh oh!

github-actions bot commented Feb 27, 2025

Uh oh!

github-actions bot commented Feb 27, 2025

Uh oh!

Uh oh!

github-actions bot commented Mar 7, 2025

Uh oh!

github-actions bot commented Mar 8, 2025

Uh oh!

vtavana left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions bot commented Mar 11, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

oleksandr-pavlyk commented Feb 10, 2025 •

edited by vtavana

Loading

github-actions bot commented Feb 10, 2025 •

edited

Loading

coveralls commented Feb 17, 2025 •

edited

Loading